Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile modal list fixes #4011

Merged
merged 4 commits into from
Dec 20, 2024
Merged

Conversation

rebelchris
Copy link
Contributor

@rebelchris rebelchris commented Dec 20, 2024

Changes

Several issues with the modal sidebar nav list.

  • it had bg-inherit (inherit was transparent) - set to bg-default now.
  • it didn't have top-0 so it offset with the new header
  • it wasn't full height so small items would show below it

Events

Did you introduce any new tracking events?

Experiment

Did you introduce any new experiments?

Manual Testing

Caution

Please make sure existing components are not breaking/affected by this PR

Preview domain

https://as-881-mobile-fix.preview.app.daily.dev

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
daily-webapp ✅ Ready (Inspect) Visit Preview Dec 20, 2024 1:30pm
1 Skipped Deployment
Name Status Preview Updated (UTC)
storybook ⬜️ Ignored (Inspect) Dec 20, 2024 1:30pm

@rebelchris rebelchris merged commit b1ad3c4 into AS-814-custom-feeds-plus Dec 20, 2024
10 checks passed
@rebelchris rebelchris deleted the AS-881-mobile-fix branch December 20, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants